This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

ais-toggle-refinement label prop does not work #667

Closed

aralikearachnid opened this issue Apr 27, 2019 · 1 comment

aralikearachnid commented Apr 27, 2019

Bug 🐞

What is the current behavior?

When using the component, passing a value to the "label" prop does not change the label of the filter.

Make a sandbox with the current behavior

This issue is visible on the live demo linked to in the docs: https://v2--vue-instantsearch.netlify.com/stories/?selectedKind=ais-toggle-refinement&selectedStory=default&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs

What is the expected behavior?

Adding a value to the "label" prop should populate ais-ToggleRefinement-labelText with the correct label.

Does this happen only in specific situations?

No

What is the proposed solution?

Check for the regression that caused this bug and revert

What is the version you are using?

"vue-instantsearch": "^2.0.1"

Always try the latest one before opening an issue.

Member

francoischalifour commented Apr 28, 2019

This issue was fixed in #649 but we haven't released a new version since. We'll let know you when we do.

Haroenv closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.