-
Notifications
You must be signed in to change notification settings - Fork 157
Conversation
@Haroenv There are still issues with conflicting Vue dependencies. Locally, I still have errors with:
|
Weird, I solved that issue I thought |
I'm surprised that this didn't break any tests 🤔 |
So am I. The Vue testing environment seems to be different: vue-instantsearch/src/components/__tests__/ToggleRefinement.js Lines 72 to 80 in e3010f6
vue-instantsearch/src/components/__tests__/__snapshots__/ToggleRefinement.js.snap Lines 65 to 83 in e3010f6
|
Can you change the test so that the name isn't the same as the label?
|
All right – the test covers more cases now. |
Netlify failures are the fault of their cache, it works consistently on my machine |
This is technically a breaking change, but small enough to ignore IMO |
* fix(toggle-refinement): display label * test(toggle-refinements): change name to free_shipping
The required
label
of theais-toggle-refinement
widget was not used in the template, thus ignored. The deployed story should display "Free shipping" but displays the attribute name "free_shipping".This issue was reported by a user.