This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ssr): fix missing scopedResults during render #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Aug 5, 2020
| scopedResults: expect.arrayContaining([ | ||
| expect.objectContaining({ | ||
| helper: expect.any(Object), | ||
| indexId: expect.any(String), |
There was a problem hiding this comment.
Why don't we assert actual values?
There was a problem hiding this comment.
Since most of the values are coming from the test itself or from mocks then we are just checking the shape of the RenderOptions object, not its actual values.
|
@Haroenv should be the same. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scopedResultsobject was missing when rendering the widget on server-side, crashing the widgets that were relying on it (likeAisCurrentRefinementsfor example).This PR fixes this by recalculating the scoped results and adding them to the render options (for this we're using the same method as in InstantSearch.js https://github.com/algolia/instantsearch.js/blob/68b20f487fcd54fd7dec11b4c494b6aa94a18516/src/widgets/index/index.ts#L154-L167)
Fixes #829