This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(vue 3): support inject without this
#951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
changed the base branch from
master
to
feat/v3-compat-define-component
eunjae-lee
commented
Apr 13, 2021
| @@ -72,6 +67,11 @@ Read more on using connectors: https://alg.li/vue-custom` | |||
| }, | |||
| }, | |||
| methods: { | |||
| getParentIndex() { | |||
There was a problem hiding this comment.
not sure if it's the best approach, though
There was a problem hiding this comment.
this makes sense, but would need to see it together with the InstantSearch change
There was a problem hiding this comment.
@Haroenv can you explain what you mean here? ↑
eunjae-lee
commented
Apr 13, 2021
| @@ -11,12 +11,7 @@ export const createWidgetMixin = ({ connector } = {}) => ({ | |||
| ); | |||
There was a problem hiding this comment.
this needs to be fixed too
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20373cf:
|
eunjae-lee
force-pushed
the
feat/v3-compat-define-component
branch
from
f40694c to
79de5a9
Compare
Base automatically changed from
feat/v3-compat-define-component
to
feat/vue3-compat
June 1, 2021 13:01
eunjae-lee
force-pushed
the
feat/v3-compat-inject
branch
from
20373cf to
878347c
Compare
eunjae-lee
added a commit
that referenced
this pull request
Jun 24, 2021
This reverts commit cf7f20a, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…instantsearch#951)" This reverts commit 8348d3d, because the issue has been fixed since Vue@3.1.2 by vuejs/core#3925
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue 3 doesn't bind
thiswhen callingdefault()of a injected variable.https://github.com/vuejs/vue-next/blob/540e26f49c09edf09b6a60ac2a978fdec52686bf/packages/runtime-core/src/apiInject.ts#L62-L64