-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated add transaction to use transaction signer instead of account object #19
base: main
Are you sure you want to change the base?
Conversation
Looks like this might be the root cause?: nodejs/undici#902 & nodejs/undici#1412 |
Furthermore, this stackoverflow page talks about this issue; https://stackoverflow.com/questions/76931498/typeerror-terminated-cause-socketerror-other-side-closed-in-fetch-nodejs The proposed solution is to use the response ; nodejs/undici#583 (comment) That would have to happen here i suppose |
How are you running your localnet? Are you using |
could you try resetting and updating your localnet to the latest version? |
@joe-p previously i was running the container in docker desktop. but i can use @iskysun96 |
So I did some poking around and it looked like there were several dangling instances of algod and postgres in my docker desktop images that was causing the problem. I deleted all images and all containers and re-ran |
@joe-p @iskysun96 With the above updates, I believe this PR is ready for re-review, thanks! |
Sorry for missing this!! Great job! 🎉 Congrats on solving the 4th Algorand Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Updated add transaction to use transaction signer instead of account object
Fix the Bug Submission Pull Request
What was the bug?
addTransaction was using an account object instead of a signer object
How did you fix the bug?
Created an account transaction signer and then sent the transaction signer instead of the account.
Ran
algokit bootstrap all
Tried running
npm run start
Got the following error:
I've made the code change that I think is correct here, but not sure what is going above... will try to look for solutions online