py-3 changes made #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Congrats on solving the 3rd Algorand Python Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is there was no actual transaction to opt in to the asa in the function opt_in_to_asset(). You can see a proper transaction written within the withdraw_asa() function.
By adding an inner transaction (itxn) with the AssetTransfer() method, we call xfer_asset=self.asset_id and asset_receiver=Global.current_application_address to ensure we're opted in to the ASA.