Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZ Integration Tests #233

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

EZ Integration Tests #233

wants to merge 8 commits into from

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Sep 9, 2022

WIP

Related PR's at various stages of WIP'ness:

Random Thoughts

  • Shouldn't we also automatically test paths?
    • In the disassemble example there is no difference between path and route. However, all the SDK's support introspecting path via a dedicated method, and the go rest client tracer ought to be able to spot this as well
    • This may obviate one sort of unit test that we always set up.
  • The POST portion of any such test, could be understood to be the setup for the READONLY GET portion. A test in indexer could pick up where the rest-client left off, and modify the fixture to include indexer queries at the end.
  • There is an SDK transaction creation unit tests with a "golden" containing the encoded signed transaction to be sent.
    • Could such a unit test be fixturized as well? Maybe not in an integration test, as absolute determinism may be required to generate the same transaction each time? Or maybe the transaction details could be asserted against instead?

@tzaffi tzaffi marked this pull request as draft September 9, 2022 13:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tzaffi
❌ Zeph Grunschlag


Zeph Grunschlag seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants