REST API: Add algod block hash endpoint, add indexer block header-only param. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Thanks for the great improvement. Definitely shutdown was missing! A couple of items:
- re-wording to clarify comments of
test-harness.sh - will we end up with the same new tags? (I put a question on the sdk-testing pr for blockhash, etc.)
- we should merge that branch (
will/misc-new-tests) first
| @@ -3,6 +3,8 @@ SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing" | |||
| SDK_TESTING_BRANCH="master" | |||
| SDK_TESTING_HARNESS="test-harness" | |||
|
|
|||
| INSTALL_ONLY=0 | |||
tzaffi
reviewed
Oct 5, 2022
tzaffi
reviewed
Oct 5, 2022
winder
force-pushed
the
will/regenerate-sdk
branch
from
f5579fd
to
19674d1
Compare
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
winder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to generated code. See commits for the generated code vs the tests.
Tests are passing locally, CI is pending algorand/algorand-sdk-testing#245