Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlimited assets : fix bug in AccountApplicationInformation handler #3702

Conversation

tsachiherman
Copy link
Contributor

Summary

AccountApplicationInformation was calling ledger.LookupResource with basics.AssetCreatable instead of basics.AppCreatable, resulting in a consistent failure.

Test Plan

Unit test will follow on a subsequent PR.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #3702 (df9d790) into feature/unlimited-assets (df44eaf) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/unlimited-assets    #3702      +/-   ##
============================================================
+ Coverage                     49.55%   49.57%   +0.02%     
============================================================
  Files                           390      390              
  Lines                         68551    68551              
============================================================
+ Hits                          33970    33986      +16     
+ Misses                        30841    30830      -11     
+ Partials                       3740     3735       -5     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
ledger/acctupdates.go 68.34% <0.00%> (ø)
ledger/tracker.go 74.67% <0.00%> (+1.28%) ⬆️
network/requestTracker.go 71.55% <0.00%> (+1.29%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/blockqueue.go 85.05% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df44eaf...df9d790. Read the comment docs.

@tsachiherman tsachiherman merged commit fe5edb3 into algorand:feature/unlimited-assets Mar 1, 2022
@tsachiherman tsachiherman deleted the tsachi/AccountApplicationInformationFix branch March 1, 2022 19:34
tsachiherman pushed a commit that referenced this pull request Mar 3, 2022
…tion (#3707)

## Summary

Follow-on to #3702, the copy-pasted code in AccountApplicationInformation was checking the wrong value before returning AppParams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants