Tests: Support e2e-go tests when repo is not installed in GOPATH. #3949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running e2e go tests fails when the repo is not cloned inside the GOPATH. This change looks up the current directory using
runtime.Caller
as an alternative to hard coding the GOPATH location.note: the Makefile also solves this problem by setting the
TESTDATADIR
environment variable, but that doesn't work when running tests from an IDE.Test Plan
Existing tests cover this code path. Additionally I manually verified by running a number of e2e-go/expect tests locally