Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algokey: Added '-v' version subcommand #3996

Closed
wants to merge 2 commits into from

Conversation

algoganesh
Copy link
Contributor

Summary

Algokey was missing a way to tell what version it's using. One should be able to run algokey -v and get the same output as goal -v.

Test Plan

algokey -v gives the same output as goal -v

@algoganesh algoganesh requested a review from winder May 17, 2022 18:16
@algoganesh algoganesh linked an issue May 17, 2022 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented May 17, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ algoganesh
❌ Ganesh Vanahalli


Ganesh Vanahalli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3996 (39902ae) into master (91095fa) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 39902ae differs from pull request most recent head 8dd6fdc. Consider uploading reports for the commit 8dd6fdc to get more accurate results

@@            Coverage Diff             @@
##           master    #3996      +/-   ##
==========================================
+ Coverage   49.77%   49.81%   +0.03%     
==========================================
  Files         409      409              
  Lines       69157    69157              
==========================================
+ Hits        34426    34452      +26     
+ Misses      31011    30983      -28     
- Partials     3720     3722       +2     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.75%) ⬇️
ledger/acctupdates.go 69.43% <0.00%> (-0.14%) ⬇️
network/wsPeer.go 68.05% <0.00%> (ø)
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
network/requestTracker.go 71.55% <0.00%> (+0.43%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91095fa...8dd6fdc. Read the comment docs.

@algoganesh algoganesh changed the title Added '-v' version subcommand to Algokey Algokey: Added '-v' version subcommand May 17, 2022
@algoganesh algoganesh closed this May 17, 2022
@algoganesh algoganesh deleted the 3992-algokey-add-version-subcommand branch May 17, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlgoKey: Add version subcommand
2 participants