Enhancement: Detect when valid partkeys represent an offline or closed account #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4030 +/- ##
==========================================
+ Coverage 54.46% 54.58% +0.11%
==========================================
Files 391 391
Lines 48665 48674 +9
==========================================
+ Hits 26506 26569 +63
+ Misses 19930 19881 -49
+ Partials 2229 2224 -5
|
AlgoStephenAkiki
force-pushed
the
2060-on-chain-warning-scenario-1
branch
from
abf8a9f to
8b16a78
Compare
winder
reviewed
May 23, 2022
winder
previously approved these changes
May 24, 2022
winder
changed the title
Resolves #2060 Puts in booleans to deduct account status from online account data and uses that to upgrade log messages to info from warnings if necessary
AlgoStephenAkiki
force-pushed
the
2060-on-chain-warning-scenario-1
branch
from
013b1ff to
4e7cca4
Compare
|
Updated PR to include all scenario warnings. |
winder
reviewed
Jun 8, 2022
winder
approved these changes
Jun 8, 2022
cce
reviewed
Jun 17, 2022
cce
reviewed
Jun 17, 2022
|
Since there are no tests, was there manual testing to identify the messages work as desired for S1/S2/S3? Or maybe you could add a test if it's not too tricky? |
|
@cce Could you look at the updated PR? |
cce
reviewed
Jul 7, 2022
cce
reviewed
Jul 7, 2022
cce
requested changes
Jul 7, 2022
winder
reviewed
Jul 8, 2022
winder
approved these changes
Jul 15, 2022
cce
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2060
Resolves all scenarios described below:
Scenario 1 (S1): Address is closed, but has a participation key that is still registered and valid given the current round number.
Scenario 2 (S2): Address is offline. Could imply no registration txn or an expired one.
Scenario 3 (S3): Address is online, with a valid participation key.
The breakdown of the scenarios by count is as follows:
S1: 7 addresses
S2: 43 addresses
S3: 2 addresses
The following actions are recommended for each scenario:
S1
Check that account is closed for the on-chain data. If account is closed, silently ignore since this account has been officially closed.
S2
Check that account is offline. If account is offline, return error indicating that no registration transaction has been issued or that previous registration transaction is expired.
S3
Recommend that error message indicates that user should regenerate participation key for the node.