Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops: Use Cloudflare API token instead of auth key #4039

Merged
merged 3 commits into from
May 27, 2022
Merged

Devops: Use Cloudflare API token instead of auth key #4039

merged 3 commits into from
May 27, 2022

Conversation

onetechnical
Copy link
Contributor

Summary

If using Cloudflare, it's preferable to use the CLOUDFLARE_API_TOKEN versus CLOUDFLARE_AUTH_KEY / CLOUDFLARE_EMAIL authentication. This is because you can striate permissions and add further lock downs to credentials.

Test Plan

Verified I could use the Cloudflare library appropriately with CLOUDFLARE_API_TOKEN.

@onetechnical onetechnical requested a review from a team May 24, 2022 16:28
@onetechnical onetechnical self-assigned this May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #4039 (7e76d29) into master (8088e04) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4039      +/-   ##
==========================================
- Coverage   54.39%   54.36%   -0.04%     
==========================================
  Files         391      391              
  Lines       48570    48570              
==========================================
- Hits        26418    26403      -15     
- Misses      19929    19939      +10     
- Partials     2223     2228       +5     
Impacted Files Coverage Δ
ledger/tracker.go 70.56% <0.00%> (-6.07%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
catchup/service.go 68.64% <0.00%> (+0.49%) ⬆️
network/wsPeer.go 68.05% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8088e04...7e76d29. Read the comment docs.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looked good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants