Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Fixing updater to accept m1 (Darwin arm64) #4099

Merged

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Jun 8, 2022

  • updated bucket to algorand-releases instead of algorand-dev-deb-repo.s3-website-us-east-1
  • removed Linux-only limitations
  • Added UPDATER_MIN_VERSION and UPDATER_CHANNEL vars to help consolidate those for easier maintenance/testing
  • tested on on darwin arm64: update itself, validate sig and checksum, update algod

@algojack algojack requested a review from a team June 8, 2022 17:35
@algojack algojack self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4099 (bf0b0a8) into master (f0c60b3) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
+ Coverage   54.45%   54.48%   +0.03%     
==========================================
  Files         391      391              
  Lines       48668    48668              
==========================================
+ Hits        26500    26518      +18     
+ Misses      19941    19926      -15     
+ Partials     2227     2224       -3     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-0.66%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
network/wsNetwork.go 64.98% <0.00%> (+0.19%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
ledger/tracker.go 73.16% <0.00%> (+2.59%) ⬆️
network/wsPeer.go 70.41% <0.00%> (+2.73%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c60b3...bf0b0a8. Read the comment docs.

cmd/updater/update.sh Show resolved Hide resolved
cmd/updater/update.sh Show resolved Hide resolved
algolucky added a commit to algolucky/tests that referenced this pull request Jun 24, 2022
algolucky
algolucky previously approved these changes Jun 24, 2022
Copy link
Contributor

@algolucky algolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these changes bring value, nice to see progress here!

I've tested these using https://github.com/algolucky/tests/tree/main/go-algorand/updater, others feel free to do the same.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me. Maybe we should also have some devs review this so they are aware of these new changes coming?

cmd/updater/update.sh Outdated Show resolved Hide resolved
@algolucky algolucky dismissed their stale review June 24, 2022 15:28

revisit later

cmd/updater/update.sh Outdated Show resolved Hide resolved
@algolucky algolucky self-requested a review June 24, 2022 16:01
@algojack algojack changed the title Tools: Fixing updater to accept m1 (Darwin arm64) >>> DO NOT MERGE <<< Tools: Fixing updater to accept m1 (Darwin arm64) >>> DO NOT MERGE <<< Jun 28, 2022
@algojack algojack changed the title >>> DO NOT MERGE <<< Tools: Fixing updater to accept m1 (Darwin arm64) >>> DO NOT MERGE <<< Tools: Fixing updater to accept m1 (Darwin arm64) Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants