-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Fixing updater to accept m1 (Darwin arm64) #4099
Tools: Fixing updater to accept m1 (Darwin arm64) #4099
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4099 +/- ##
==========================================
+ Coverage 54.45% 54.48% +0.03%
==========================================
Files 391 391
Lines 48668 48668
==========================================
+ Hits 26500 26518 +18
+ Misses 19941 19926 -15
+ Partials 2227 2224 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these changes bring value, nice to see progress here!
I've tested these using https://github.com/algolucky/tests/tree/main/go-algorand/updater, others feel free to do the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me. Maybe we should also have some devs review this so they are aware of these new changes coming?
algorand-releases
instead ofalgorand-dev-deb-repo.s3-website-us-east-1