Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: remove unused genesis in stash #4155

Merged

Conversation

algolucky
Copy link
Contributor

@algolucky algolucky commented Jun 21, 2022

Summary

  • removes the installer/ genesis files from the stash steps because it was determined that they were used for integration tests, and those tests are no longer being done in that pipeline

@algolucky algolucky self-assigned this Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4155 (00017ff) into master (c6a4ddc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4155      +/-   ##
==========================================
- Coverage   54.56%   54.53%   -0.04%     
==========================================
  Files         391      391              
  Lines       48732    48732              
==========================================
- Hits        26592    26576      -16     
- Misses      19921    19932      +11     
- Partials     2219     2224       +5     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-3.04%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.25%) ⬇️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a4ddc...00017ff. Read the comment docs.

@algolucky algolucky marked this pull request as ready for review June 21, 2022 17:57
@algolucky algolucky requested review from a team, egieseke, algobarb and algojack June 21, 2022 19:00
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants