Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Don't allocate when invoking the Inc() fastpath #4193

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jannotti
Copy link
Contributor

Almost trivial optimization. No new tests.

@jannotti jannotti self-assigned this Jun 28, 2022
@jannotti jannotti requested a review from cce June 28, 2022 17:49
@jannotti jannotti changed the title Don't allocate when invoking the Inc() fastpath Metrics: Don't allocate when invoking the Inc() fastpath Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4193 (f569143) into master (8e845fb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4193      +/-   ##
==========================================
- Coverage   54.56%   54.55%   -0.01%     
==========================================
  Files         391      391              
  Lines       48788    48788              
==========================================
- Hits        26620    26616       -4     
- Misses      19937    19950      +13     
+ Partials     2231     2222       -9     
Impacted Files Coverage Δ
crypto/curve25519.go 61.81% <100.00%> (ø)
network/wsPeer.go 65.47% <0.00%> (-3.02%) ⬇️
node/node.go 22.38% <0.00%> (-1.94%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
catchup/service.go 68.88% <0.00%> (+0.74%) ⬆️
data/transactions/verify/txn.go 44.88% <0.00%> (+0.88%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/tracker.go 73.16% <0.00%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e845fb...f569143. Read the comment docs.

@jannotti jannotti requested a review from brianolson June 28, 2022 18:33
@jannotti jannotti marked this pull request as ready for review June 28, 2022 19:07
@jannotti jannotti merged commit ae17d8e into algorand:master Jun 28, 2022
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants