Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: fix linter errors and update CI to require passing #4241

Merged
merged 20 commits into from
Aug 18, 2022
Merged

lint: fix linter errors and update CI to require passing #4241

merged 20 commits into from
Aug 18, 2022

Commits on Jul 7, 2022

  1. fix golangci-lint errors

    @cce
    cce committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    bc6c75c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. fix new lint errors

    @cce
    cce committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    389c6d6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into golangci-lint-clean

    @cce
    cce committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    2e1ef20 View commit details
    Browse the repository at this point in the history

  3. update for latest master

    @cce
    cce committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    675dcf2 View commit details
    Browse the repository at this point in the history

  4. switch to github-pr-check, github-pr-review not working

    @cce
    cce committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    18c51fe View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge remote-tracking branch 'upstream/master' into golangci-lint-clean

    @cce
    cce committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    25a2071 View commit details
    Browse the repository at this point in the history

  2. fix latest linter errors from master

    @cce
    cce committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    4fefd94 View commit details
    Browse the repository at this point in the history

  3. codec_tester: make randomizeValue generate valid HashType values

    @cce
    cce committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    504bd3d View commit details
    Browse the repository at this point in the history

  4. demote deleteLedgerFiles to nolint:errcheck

    @cce
    cce committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1c3d9c7 View commit details
    Browse the repository at this point in the history

  5. codec_tester: find more HashType fields (in merklearray.Tree)

    @cce
    cce committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    8e9c6fb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. fix codec_tester when used with pointer fields

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    8c56e36 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into golangci-lint-clean

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    7b23968 View commit details
    Browse the repository at this point in the history

  3. explain ignoring shakehash read/write

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5cf4dc3 View commit details
    Browse the repository at this point in the history

  4. codec_tester: be more precise in identifying crypto.HashType

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    76442f5 View commit details
    Browse the repository at this point in the history

  5. improve codec_tester performance a little bit

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    638a31a View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into golangci-lint-clean

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1925ea0 View commit details
    Browse the repository at this point in the history

  7. clean for nolintlint, golint, staticcheck, typecheck

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    c6b1486 View commit details
    Browse the repository at this point in the history

  8. fix panic in goal app flags

    @cce
    cce committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    f3c3d3e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. TestRandomizeObjectWithPtrField: run a few and fail if all zero

    @cce
    cce committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    20952b7 View commit details
    Browse the repository at this point in the history

  2. codec_tester: split u16 and u64 tests

    @cce
    cce committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b563b39 View commit details
    Browse the repository at this point in the history