Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Don't parallelize tests that use shared for loop var #4253

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

jannotti
Copy link
Contributor

Fix to run tests properly, no non-test changes.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4253 (64bd903) into master (9e91460) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4253   +/-   ##
=======================================
  Coverage   55.10%   55.11%           
=======================================
  Files         395      395           
  Lines       50117    50117           
=======================================
+ Hits        27619    27624    +5     
+ Misses      20122    20116    -6     
- Partials     2376     2377    +1     
Impacted Files Coverage Δ
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
network/wsPeer.go 67.94% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e91460...64bd903. Read the comment docs.

@jannotti jannotti marked this pull request as ready for review July 16, 2022 20:01
@jannotti jannotti requested a review from cce July 18, 2022 15:26
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good strong message, you tell'em

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants