tools: goal logging send fixes #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send only as many bytes as exist in the log when we stat() it (log may still be growing) otherwise S3 breaks if any action within `goal logging send` fails, return error and exit with error
algonautshant
approved these changes
Jul 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
- Coverage 55.29% 55.25% -0.04%
==========================================
Files 395 395
Lines 50334 50341 +7
==========================================
- Hits 27833 27817 -16
- Misses 20117 20137 +20
- Partials 2384 2387 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
algorandskiy
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Send only as many bytes as exist in the log when we stat() it (log may still be growing) otherwise S3 breaks.
If any action within
goal logging sendfails, return error and exit with error.Test Plan
Problems found during development. Development tool works better now.