tools: pingpong improvements #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can configure one pingpong to deliver a weighted mix of traffic libgoal can optionally keep cache of SuggestedParams so that it doesn't query before every construct-txn pingpong can use deterministic accounts that are reusable across pingpong runs
Codecov Report
@@ Coverage Diff @@
## master #4294 +/- ##
==========================================
- Coverage 55.25% 54.00% -1.26%
==========================================
Files 398 401 +3
Lines 50297 51467 +1170
==========================================
+ Hits 27793 27795 +2
- Misses 20171 21336 +1165
- Partials 2333 2336 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
allows two pingpongs to do e.g. accounts 0..49 and 50..99
egieseke
approved these changes
Aug 31, 2022
| runCmd.Flags().Int64Var(&randSeed, "seed", 0, "input to math/rand.Seed(), defaults to time.Now().UnixNano()") | ||
| runCmd.Flags().BoolVar(&deterministicKeys, "deterministicKeys", false, "Draw from set of netgoal-created accounts using deterministic keys") | ||
| runCmd.Flags().Uint32Var(&generatedAccountsCount, "genaccounts", 0, "The total number of accounts pre-generated by netgoal") | ||
| runCmd.Flags().StringVar(&generatedAccountSampleMethod, "gensamplemethod", "random", "The method of sampling from the total # of pre-generated accounts") | ||
| } |
There was a problem hiding this comment.
Do the pre-generated accounts get automatically topped off from a source account?
There was a problem hiding this comment.
There's code to make low balance accounts the destination of natural traffic, so they'll tend to refill.
| @@ -90,6 +111,8 @@ var DefaultConfig = PpConfig{ | |||
| Rekey: false, | |||
| MaxRuntime: 0, | |||
|
|
|||
| ProgramProbability: 1, | |||
There was a problem hiding this comment.
The probability of using a LogicSig
jannotti
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
can configure one pingpong to deliver a weighted mix of traffic
libgoal can optionally keep cache of SuggestedParams so that it doesn't query before every construct-txn
pingpong can use deterministic accounts that are reusable across pingpong runs
deterministic account code by @cce
Test Plan
pingpongis a test tool I have been using to test algod private networks