Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: touch fields_string.go so everything is rebuilt in codegen verification #4330

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Aug 1, 2022

Since we commit some products of the make, but our goal is to ensure those products are exactly what would be generated, we have to force the generation to actually happen.

@jannotti jannotti changed the title touch fields.go so everythign is rebuilt in codegen verification Test: touch fields.go so everythign is rebuilt in codegen verification Aug 1, 2022
@jannotti jannotti force-pushed the ensure-spec-rebuild branch from 35d8ee0 to 21b74ba Compare August 1, 2022 15:00
@jannotti jannotti changed the title Test: touch fields.go so everythign is rebuilt in codegen verification Test: touch fields.go so everything is rebuilt in codegen verification Aug 1, 2022
@jannotti jannotti changed the title Test: touch fields.go so everything is rebuilt in codegen verification Test: touch fields_string.go so everything is rebuilt in codegen verification Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4330 (21b74ba) into master (09607f1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4330      +/-   ##
==========================================
- Coverage   55.26%   55.25%   -0.02%     
==========================================
  Files         395      395              
  Lines       50334    50334              
==========================================
- Hits        27818    27811       -7     
- Misses      20131    20137       +6     
- Partials     2385     2386       +1     
Impacted Files Coverage Δ
util/db/dbutil.go 49.09% <0.00%> (-1.22%) ⬇️
data/transactions/verify/txn.go 44.00% <0.00%> (-0.89%) ⬇️
ledger/tracker.go 76.29% <0.00%> (-0.87%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
network/wsPeer.go 68.21% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jannotti jannotti marked this pull request as ready for review August 1, 2022 17:22
@jannotti jannotti requested a review from michaeldiamant August 1, 2022 17:22
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jannotti Thanks for looking into it!

For other folks looking in, the PR ought to address failures like https://app.circleci.com/pipelines/github/algorand/go-algorand/8121/workflows/62a49324-75d4-4f08-8252-ca022937e119/jobs/145986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants