Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Fix crypto benchmarks from bitrot #4340

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Aug 2, 2022

We don't run benchmarks in CI, so we didn't notice that some of them failed.

@jannotti jannotti changed the title Fix crypto benchmarks from bitrot AVM: Fix crypto benchmarks from bitrot Aug 2, 2022
@jannotti jannotti force-pushed the fix-crypto-benchmark branch from 023da10 to b92e04c Compare August 2, 2022 17:17
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4340 (b92e04c) into master (09607f1) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4340      +/-   ##
==========================================
+ Coverage   55.26%   55.28%   +0.01%     
==========================================
  Files         395      395              
  Lines       50334    50334              
==========================================
+ Hits        27818    27826       +8     
+ Misses      20131    20122       -9     
- Partials     2385     2386       +1     
Impacted Files Coverage Δ
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/logic/assembler.go 85.16% <0.00%> (+0.07%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
ledger/acctupdates.go 70.52% <0.00%> (+0.60%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
ledger/tracker.go 78.87% <0.00%> (+1.72%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jannotti jannotti marked this pull request as ready for review August 2, 2022 18:02
@jannotti jannotti requested a review from iten-alg August 2, 2022 18:02
Copy link
Contributor

@iten-alg iten-alg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jannotti jannotti merged commit 1f7a49e into algorand:master Aug 2, 2022
@jannotti jannotti deleted the fix-crypto-benchmark branch August 2, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants