-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: set pprof labels for goroutines that use the same code for different cases #4350
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4350 +/- ##
=======================================
Coverage 55.87% 55.88%
=======================================
Files 482 482
Lines 68571 68578 +7
=======================================
+ Hits 38317 38325 +8
+ Misses 27652 27650 -2
- Partials 2602 2603 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. The docs on pprof.Do weren't really helpful for me, and I haven't spent a lot of time with profiling. It looks correct according to the blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you decide what to label? git grep "go.*()"
and dig around? Or stuff you knew was interesting?
655672a
to
f458336
Compare
@cce could you rebase it? |
I suggest not merging before p2p branch due to conflicts |
This sets a few profiler labels to identify a selection of goroutines used by algod. Since profiler data already lets you filter by function, we only need labels for cases where the same function is used by multiple goroutines for different cases. (E.g. low-prority worker pool vs high-priority worker pool; dedicated deserialization goroutines for different message types)