Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Control the specs generated seperately from logic.LogicVersion #4361

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Aug 5, 2022

This will keep the generated specs on v7 even if logic.LogicVersion goes to 8.

@jannotti jannotti marked this pull request as ready for review August 5, 2022 00:00
@jannotti jannotti requested a review from algorandskiy August 5, 2022 00:00
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #4361 (344f9ed) into master (38420a4) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4361      +/-   ##
==========================================
+ Coverage   55.24%   55.26%   +0.02%     
==========================================
  Files         395      395              
  Lines       50352    50352              
==========================================
+ Hits        27816    27828      +12     
+ Misses      20144    20138       -6     
+ Partials     2392     2386       -6     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/tracker.go 76.49% <0.00%> (-0.86%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.75%) ⬇️
ledger/acctupdates.go 69.92% <0.00%> (-0.61%) ⬇️
network/wsNetwork.go 64.89% <0.00%> (+0.19%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
util/db/dbutil.go 50.30% <0.00%> (+1.21%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants