Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: make txBacklogSize responsive to block size #4377

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

brianolson
Copy link
Contributor

Summary

Make a channel length txBacklogSize responsive to up coming changes in block size. Hold approximately one block of txns in channel. Manual testing has shown that txBacklogSize needs to be increased from its original size of 1000.

Test Plan

Manually experimented and verified in cluster tests.

@gmalouf gmalouf requested a review from algorandskiy August 9, 2022 19:44
@gmalouf gmalouf requested a review from cce August 9, 2022 20:00
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4377 (8549fb7) into master (60fb4f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4377      +/-   ##
==========================================
- Coverage   55.60%   55.59%   -0.01%     
==========================================
  Files         403      403              
  Lines       50801    50801              
==========================================
- Hits        28248    28244       -4     
- Misses      20159    20162       +3     
- Partials     2394     2395       +1     
Impacted Files Coverage Δ
data/txHandler.go 0.00% <ø> (ø)
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctupdates.go 70.37% <0.00%> (-0.16%) ⬇️
ledger/tracker.go 78.63% <0.00%> (ø)
catchup/service.go 69.38% <0.00%> (ø)
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
util/db/dbutil.go 50.30% <0.00%> (+1.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants