Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestAccountsCanSendMoney #3 #4379

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2022

Summary

The TestAccountsCanSendMoney test does not throw an error when not all txns are confirmed within the allotted time. This pr fixes that so we can have better understanding of why the test fails.

Test Plan

This is a test.

@ghost ghost requested a review from algorandskiy August 9, 2022 18:17
@ghost ghost self-assigned this Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4379 (0f9d64d) into master (60fb4f6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
- Coverage   55.60%   55.58%   -0.03%     
==========================================
  Files         403      403              
  Lines       50801    50801              
==========================================
- Hits        28248    28236      -12     
- Misses      20159    20170      +11     
- Partials     2394     2395       +1     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/service.go 68.14% <0.00%> (-1.24%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/verify/txn.go 43.85% <0.00%> (-0.88%) ⬇️
ledger/acctupdates.go 70.22% <0.00%> (-0.31%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/tracker.go 80.34% <0.00%> (+1.70%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@algorandskiy
Copy link
Contributor

  • the test did not throw an error when not all txns are confirmed within the allotted time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants