Bugfix: download more block to recover old state proofs #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id-ms
force-pushed
the
fix-fast-catchup-blocks-bug
branch
from
9ae6279
to
a9403da
Compare
Codecov Report
@@ Coverage Diff @@
## master #4392 +/- ##
==========================================
+ Coverage 55.57% 55.59% +0.01%
==========================================
Files 403 403
Lines 50805 50806 +1
==========================================
+ Hits 28235 28244 +9
+ Misses 20175 20165 -10
- Partials 2395 2397 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 11, 2022
| lowestStateProofRound = lowestStateProofRound.SubSaturate(basics.Round(proto.StateProofInterval)) | ||
| lowestStateProofRound = lowestStateProofRound.SubSaturate(basics.Round(proto.StateProofVotersLookback)) |
There was a problem hiding this comment.
agree, we do need voters lookback
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Aug 15, 2022
…gorand#4392) A fast-caught up node should be able to be part of state proofs creation and must download all necessary blocks. Currently, if the state proof chain is lagging the node download lowestStateProofRound - stateproofInterval rounds back on fast catchup. This is not accurate since the balances comes from lowestStateProofRound - stateproofInterval - StateProofVotersLookback round.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A fast-catchuped node should be able to be part of state proofs creation. In order to do that, it must download all necessary blocks. Currently, if the state proof chain is lagging the node download
lowestStateProofRound - stateproofIntervalrounds back on fast catchup. This is not accurate since the balances comes fromlowestStateProofRound - stateproofInterval - StateProofVotersLookbackTest Plan
Manual fast catchup test.