CICD: Macos11 support #4399
Merged
CICD: Macos11 support #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for MacOS 11
Codecov Report
@@ Coverage Diff @@
## master #4399 +/- ##
==========================================
+ Coverage 55.19% 55.25% +0.05%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 27689 27717 +28
+ Misses 20159 20140 -19
+ Partials 2317 2308 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algolucky
previously approved these changes
Aug 19, 2022
egieseke
previously approved these changes
Aug 19, 2022
| @@ -673,7 +673,7 @@ jobs: | |||
| - run: | |||
| no_output_timeout: 45m | |||
| command: | | |||
| #export PATH=$(echo "$PATH" | sed -e 's|:/home/circleci/\.go_workspace/bin||g' | sed -e 's|:/usr/local/go/bin||g') | |||
| # export PATH=$(echo "$PATH" | sed -e 's|:/home/circleci/\.go_workspace/bin||g' | sed -e 's|:/usr/local/go/bin||g') | |||
There was a problem hiding this comment.
because ide added a space
There was a problem hiding this comment.
if you are asking why the command is there, i don't know. I think we were trying to cut out homebrew path and golang path from path env var. But since it works without this for now, maybe it's not needed at all.
There was a problem hiding this comment.
since we don't currently run that workflow (windows build) I can't say for sure, and don't want to remove it until we test if we need it or not.
egieseke
approved these changes
Aug 22, 2022
algolucky
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running in circleci: https://app.circleci.com/pipelines/github/algorand/go-algorand/8694/workflows/2e801391-7eaa-4f5f-a522-9ad05b49326c