test: deprecate TestAsyncRecord #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
winder
approved these changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #4407 +/- ##
==========================================
- Coverage 55.57% 55.34% -0.24%
==========================================
Files 400 400
Lines 50797 50797
==========================================
- Hits 28231 28112 -119
- Misses 20169 20311 +142
+ Partials 2397 2374 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the TestAsyncRecord test, as per discussion with @winder. The goal of this test was supposed to ensure that recording participation keys properly updates the db. The test does not test functionality that we wish to test and is also flaking on circle ci. Additionally, all the behavior we wish to verify is tested within
test/scripts/e2e_subs/goal-partkey-commands.sh.Test Plan
this is a test