Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: stop network before reading logs #4429

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

Test random failures debugging: retrieve logs after stopping the network to ensure all messages were flushed.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #4429 (38472f3) into master (bf7aaec) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4429      +/-   ##
==========================================
+ Coverage   55.18%   55.24%   +0.05%     
==========================================
  Files         398      398              
  Lines       50137    50137              
==========================================
+ Hits        27669    27697      +28     
+ Misses      20156    20136      -20     
+ Partials     2312     2304       -8     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
data/transactions/verify/txn.go 43.85% <0.00%> (-0.88%) ⬇️
ledger/acctupdates.go 69.29% <0.00%> (-0.60%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (ø)
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️
agreement/cryptoVerifier.go 72.53% <0.00%> (+4.92%) ⬆️
network/wsPeer.go 70.95% <0.00%> (+5.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant