alphanet: merge build changes and consensus params #4431
Conversation
Re-merge master into alphanet
…orand into feature/alphanet
…orand into feature/alphanet
DevOps: Update alphanet topology
…d to "alphanet.algodev.network".
Adjust the DNS Bootstrap Id for Alphanet
alphanet: define vAlpha2 consensus parameters
DevOps: Updated alphanet algonet recipe genesis files to use alpha2 protocol.
Fixing rpm package name for alphanet
cce
changed the title
cce
dismissed stale reviews from egieseke, algolucky, and onetechnical
via
2eb6419
| "VersionModifier": "", | ||
| "ConsensusProtocol": "alpha1", |
There was a problem hiding this comment.
why did we change genesis'proto?
There was a problem hiding this comment.
I believe we update this for performance testing. The live network genesis doesn't change (it's in the installer dir) but we need to keep this updated.
There was a problem hiding this comment.
This is just to make the Jenkins tests running the "alphanet" recipe start up from the latest version — the real alphanet genesis is in installer/genesis/alphanet/genesis.json. I guess another approach would be to have an alphacurrent or alphafuture version defined to set this to
| a.True(leadsTo, "Consensus protocol must have upgrade path from %v to %v", currentVersionName, latestVersionName) | ||
| } | ||
|
|
||
| func consensusUpgradesTo(a *require.Assertions, currentName, targetName protocol.ConsensusVersion) bool { | ||
| func checkConsensusVersionName(a *require.Assertions, name string) { | ||
| // ensure versions come from official specs repo |
There was a problem hiding this comment.
why is this check important?
There was a problem hiding this comment.
I believe this is a sanity check to ensure we don't accidentally enable vAlpha in official builds.
There was a problem hiding this comment.
yes it was an idea I had before merging these alternate consensus versions, that I should add something to be extra careful to ensure a version like "alpha3" doesn't make it into the path from v7 to ConsensusCurrentVersion and into a release
Summary
This merges in a few changes related to alphanet
Test Plan
Existing tests should pass.
Added a new test to assert that non-official consensus version names (like "alpha3") don't make it into the upgrade history to ConsensusCurrentVersion.