Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: ioutil is deprecated, I have the power of search and replace #4440

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

jannotti
Copy link
Contributor

Should all be obvious updates.

@jannotti jannotti changed the title ioutil is deprecated, I have the power of search and replace Lint: ioutil is deprecated, I have the power of search and replace Aug 20, 2022
@jannotti jannotti force-pushed the deprecate-ioutil branch 2 times, most recently from f57231b to 11ec78d Compare August 20, 2022 00:57
@jannotti jannotti marked this pull request as ready for review August 20, 2022 01:34
@jannotti jannotti requested review from winder and cce August 20, 2022 01:36
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #4440 (293d2b3) into master (9c6753e) will decrease coverage by 0.01%.
The diff coverage is 3.37%.

@@            Coverage Diff             @@
##           master    #4440      +/-   ##
==========================================
- Coverage   55.23%   55.21%   -0.02%     
==========================================
  Files         398      398              
  Lines       50148    50165      +17     
==========================================
+ Hits        27699    27700       +1     
- Misses      20135    20152      +17     
+ Partials     2314     2313       -1     
Impacted Files Coverage Δ
cmd/algod/main.go 0.00% <0.00%> (ø)
cmd/algofix/main.go 1.50% <0.00%> (ø)
cmd/algofix/typecheck.go 0.00% <0.00%> (ø)
cmd/algoh/main.go 0.00% <0.00%> (ø)
cmd/catchupsrv/download.go 12.79% <0.00%> (ø)
cmd/catchupsrv/main.go 0.00% <0.00%> (ø)
cmd/goal/account.go 12.62% <0.00%> (ø)
cmd/goal/accountsList.go 0.00% <0.00%> (ø)
cmd/goal/commands.go 10.40% <0.00%> (ø)
cmd/goal/multisig.go 10.00% <0.00%> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti merged commit 7932403 into algorand:master Aug 20, 2022
@jannotti jannotti deleted the deprecate-ioutil branch August 20, 2022 02:22
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants