AVM: Handle Teal programs with manual constant blocks better #4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
changed the title
jannotti
force-pushed
the
dead-constants
branch
from
f09fd44
to
783a9bf
Compare
This PR fixes algorand#4034, by forcing the use of "push*" when mixing manual constant blocks with the int/byte/addr/method pseudo-ops. (And a related disassembly bug). However, to avoid this "deoptimization" when manual blocks are used to add program metadata, deadcode constant blocks are ignored for this check.
jannotti
force-pushed
the
dead-constants
branch
from
783a9bf
to
7990b5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4442 +/- ##
==========================================
- Coverage 55.24% 55.19% -0.05%
==========================================
Files 398 398
Lines 50165 50196 +31
==========================================
- Hits 27712 27705 -7
- Misses 20144 20176 +32
- Partials 2309 2315 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
michaeldiamant
previously approved these changes
Aug 30, 2022
There was a problem hiding this comment.
@jannotti Nice work to identify + implement a more correct handling of constant blocks ☕
jannotti
force-pushed
the
dead-constants
branch
from
a976210
to
7893fa4
Compare
michaeldiamant
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4034, by forcing the use of "push*" when mixing manual
constant blocks with the int/byte/addr/method pseudo-ops. (And a
related disassembly bug).
However, to avoid this "deoptimization" when manual blocks are used to
add program metadata, deadcode constant blocks are ignored for this
check.
Tests for the problems in #4034 and additional tests for the deadcode were added.