Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make windows build faster #4443

Merged
merged 20 commits into from
Aug 24, 2022
Merged

Conversation

cce
Copy link
Contributor

@cce cce commented Aug 22, 2022

Summary

This makes the GHA Windows build job use Go module caching (by upgrading to actions/setup-go@v3) and caching for libsodium (by using actions/cache). Brings the Windows build time down from ~22 minutes to ~10 minutes.

Test Plan

Tests should pass and run faster.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #4443 (f8c21f9) into master (87867c9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4443      +/-   ##
==========================================
- Coverage   55.26%   55.25%   -0.02%     
==========================================
  Files         398      398              
  Lines       50263    50263              
==========================================
- Hits        27780    27774       -6     
- Misses      20167    20174       +7     
+ Partials     2316     2315       -1     
Impacted Files Coverage Δ
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
data/transactions/verify/txn.go 43.75% <0.00%> (-0.90%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.75%) ⬇️
ledger/accountdb.go 73.02% <0.00%> (+0.15%) ⬆️
network/wsNetwork.go 64.82% <0.00%> (+0.19%) ⬆️
ledger/acctonline.go 78.89% <0.00%> (+0.52%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce
Copy link
Contributor Author

cce commented Aug 23, 2022

For some reason, GHA Go builds on Windows fail due to checksum mismatches:

just encountered

verifying github.com/consensys/gnark-crypto@v0.7.0: checksum mismatch
	downloaded: h1:pxGDRS9ZNRQaXlAJPigJ1Nc9HPwCPKrJjUF/0SgNFmA=
	go.sum:     h1:rwdy8+ssmLYRqKp+ryRRgQJl/rCq2uv+n83cOydm5UE=

before that I got this error, which I fixed by pushing a new v1.1.9 release

verifying github.com/algorand/go-codec/codec@v1.1.8: checksum mismatch
	downloaded: h1:RyokOQSEnNCxrngGqC5yrPNoQAGh5osBIKiaeKOe5fg=
	go.sum:     h1:lsFuhcOH2LiEhpBH3BVUUkdevVmwCRyvb7FCAAPeY6U=

@cce cce mentioned this pull request Aug 23, 2022
algobarb
algobarb previously approved these changes Aug 24, 2022
Makefile Show resolved Hide resolved
algolucky
algolucky previously approved these changes Aug 24, 2022
@cce cce dismissed stale reviews from algolucky and algobarb via e2c7fae August 24, 2022 14:47
algolucky
algolucky previously approved these changes Aug 24, 2022
@algolucky algolucky dismissed their stale review August 24, 2022 16:43

let's specify version in setup-go step

@cce cce merged commit e6bd9a3 into algorand:master Aug 24, 2022
@cce cce deleted the cache-windows-libsodium branch August 24, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants