-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: make windows build faster #4443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4443 +/- ##
==========================================
- Coverage 55.26% 55.25% -0.02%
==========================================
Files 398 398
Lines 50263 50263
==========================================
- Hits 27780 27774 -6
- Misses 20167 20174 +7
+ Partials 2316 2315 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For some reason, GHA Go builds on Windows fail due to checksum mismatches: just encountered
before that I got this error, which I fixed by pushing a new v1.1.9 release
|
cce
requested review from
a team,
algobarb,
algojack,
algolucky and
onetechnical
August 24, 2022 13:54
algobarb
previously approved these changes
Aug 24, 2022
algojack
reviewed
Aug 24, 2022
algolucky
reviewed
Aug 24, 2022
algolucky
previously approved these changes
Aug 24, 2022
algolucky
previously approved these changes
Aug 24, 2022
algojack
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the GHA Windows build job use Go module caching (by upgrading to actions/setup-go@v3) and caching for libsodium (by using actions/cache). Brings the Windows build time down from ~22 minutes to ~10 minutes.
Test Plan
Tests should pass and run faster.