Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Get rid of references and uses of go lint and go vet #4444

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

jannotti
Copy link
Contributor

golangci-lint subsumes both of these tools

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #4444 (80246b7) into master (e4d6d42) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
+ Coverage   55.19%   55.21%   +0.02%     
==========================================
  Files         398      398              
  Lines       50165    50165              
==========================================
+ Hits        27689    27700      +11     
+ Misses      20159    20150       -9     
+ Partials     2317     2315       -2     
Impacted Files Coverage Δ
ledger/acctonline.go 78.36% <0.00%> (-0.53%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (-0.20%) ⬇️
catchup/service.go 69.38% <0.00%> (ø)
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti marked this pull request as ready for review August 22, 2022 16:36
# Work our way back over time to be clean against all these
# checkers. If you'd like to contribute, raise the number after ~,
# run the linter and dig in.
new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57~25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants