Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: TestSlowPeerDisconnect less flakey #4453

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

brianolson
Copy link
Contributor

Summary

sleeping 1ms can still starve other processes sometimes.
sleep 10ms to let the test run.
test used to fail about 1/200; haven't seen a failure in several thousand now.

Test Plan

This is a test. It should be less flakey now.

sleep 10ms to let the test run
test used to fail about 1/200; haven't seen a failure in several thousand now.
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Brian

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #4453 (2d7580c) into master (924d2fb) will increase coverage by 3.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
+ Coverage   51.51%   55.19%   +3.68%     
==========================================
  Files         398      398              
  Lines       50165    50165              
==========================================
+ Hits        25841    27691    +1850     
+ Misses      21934    20160    -1774     
+ Partials     2390     2314      -76     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.44%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (+0.09%) ⬆️
ledger/internal/prefetcher/prefetcher.go 68.18% <0.00%> (+0.45%) ⬆️
node/node.go 4.43% <0.00%> (+0.47%) ⬆️
util/db/dbutil.go 44.24% <0.00%> (+0.60%) ⬆️
daemon/algod/api/server/v2/dryrun.go 70.82% <0.00%> (+0.60%) ⬆️
agreement/pseudonode.go 70.07% <0.00%> (+0.72%) ⬆️
ledger/catchpointwriter.go 57.65% <0.00%> (+0.90%) ⬆️
ledger/acctonline.go 78.36% <0.00%> (+1.05%) ⬆️
... and 112 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants