Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: extend catchpoint blocks lookback #4463

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

  • replaying transactions after catchpoint requires 1001 blocks
    from the very first replayed block

Test Plan

Tested manually. e2e test planned as a separate PR

* replaying transactions after catchpoint requires 1001 blocks
  from the very first replayed block
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4463 (dcd9ca0) into master (7de989a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4463      +/-   ##
==========================================
- Coverage   55.23%   55.23%   -0.01%     
==========================================
  Files         398      398              
  Lines       50276    50276              
==========================================
- Hits        27772    27771       -1     
+ Misses      20188    20185       -3     
- Partials     2316     2320       +4     
Impacted Files Coverage Δ
catchup/catchpointService.go 1.77% <0.00%> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
data/transactions/verify/txn.go 43.75% <0.00%> (-0.90%) ⬇️
ledger/tracker.go 74.04% <0.00%> (-0.86%) ⬇️
ledger/acctonline.go 78.12% <0.00%> (-0.53%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (-0.20%) ⬇️
ledger/accountdb.go 72.87% <0.00%> (-0.16%) ⬇️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
catchup/service.go 69.62% <0.00%> (+1.48%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 00a6150 into algorand:master Aug 25, 2022
onetechnical pushed a commit to onetechnical/go-algorand that referenced this pull request Aug 26, 2022
* replaying transactions after catchpoint requires 1001 blocks
  from the very first replayed block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants