Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: fix catchpoint test #4480

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2022

Summary

Fixed the TestCatchpointReadDatabaseOverflowAccounts test. It was failing because multiple resources were being created with the same id, since the test first creates resources with id's as a random slice between 0 and 512, and then counting up from 100. This pr changes the latter set of resources to count up from 1000 to avoid the conflict.

Test Plan

This is a test

@ghost ghost self-assigned this Aug 26, 2022
@ghost ghost added the Team Carbon-11 label Aug 26, 2022
@ghost ghost requested a review from cce August 26, 2022 17:18
@ghost ghost added the Bug-Fix label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #4480 (8d96b55) into master (e931e07) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4480      +/-   ##
==========================================
- Coverage   55.21%   55.18%   -0.03%     
==========================================
  Files         398      398              
  Lines       50276    50276              
==========================================
- Hits        27758    27747      -11     
- Misses      20185    20192       +7     
- Partials     2333     2337       +4     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.83%) ⬇️
ledger/catchpointtracker.go 62.10% <0.00%> (-0.79%) ⬇️
catchup/service.go 68.14% <0.00%> (-0.50%) ⬇️
network/wsNetwork.go 64.82% <0.00%> (-0.29%) ⬇️
ledger/accountdb.go 72.72% <0.00%> (-0.16%) ⬇️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+4.02%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants