Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes more of AccountData to AVM #4491

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Aug 31, 2022

Getting this on our radar. I think exposing these fields would help apps that want to keep an eye on their MBR.

The only thing that is potentially worth exposing now is Status I'd rather ignore it for now (see explanation in a comment below). Debate me!

@jannotti jannotti marked this pull request as ready for review September 2, 2022 11:54
@jannotti jannotti requested a review from jasonpaulos September 9, 2022 01:48
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I just have some comments.

@algorand algorand deleted a comment from codecov bot Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #4491 (f06bce6) into feature/avm-box (31037ed) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           feature/avm-box    #4491      +/-   ##
===================================================
- Coverage            55.48%   55.38%   -0.10%     
===================================================
  Files                  408      405       -3     
  Lines                51525    51523       -2     
===================================================
- Hits                 28590    28538      -52     
- Misses               20510    20550      +40     
- Partials              2425     2435      +10     
Impacted Files Coverage Δ
data/transactions/logic/fields.go 75.12% <ø> (ø)
data/transactions/logic/fields_string.go 44.44% <ø> (ø)
data/transactions/logic/eval.go 89.32% <100.00%> (+0.06%) ⬆️
ledger/tracker.go 74.78% <0.00%> (-6.42%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-6.03%) ⬇️
catchup/service.go 69.38% <0.00%> (-2.97%) ⬇️
util/db/dbutil.go 48.48% <0.00%> (-1.82%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
ledger/acctonline.go 79.00% <0.00%> (-0.53%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti
Copy link
Contributor Author

I'm going to merge this to the feature branch without doing anything about Status around 4pm unless I hear objections. Objections should express an opinion about how it should be exposed.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@jannotti jannotti merged commit 2f360f6 into algorand:feature/avm-box Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants