-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes more of AccountData to AVM #4491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, I just have some comments.
5b22bd6
to
b1e11cd
Compare
Codecov Report
@@ Coverage Diff @@
## feature/avm-box #4491 +/- ##
===================================================
- Coverage 55.48% 55.38% -0.10%
===================================================
Files 408 405 -3
Lines 51525 51523 -2
===================================================
- Hits 28590 28538 -52
- Misses 20510 20550 +40
- Partials 2425 2435 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm going to merge this to the feature branch without doing anything about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Getting this on our radar. I think exposing these fields would help apps that want to keep an eye on their MBR.
The only thing that is potentially worth exposing now is
Status
I'd rather ignore it for now (see explanation in a comment below). Debate me!