-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: TagCounter gains a tag set to filter on #4503
Conversation
unknown tags can be counted under one substitute tag e.g. "UNK" limit protocol counters to known protocol tags
Codecov Report
@@ Coverage Diff @@
## master #4503 +/- ##
==========================================
- Coverage 55.25% 55.22% -0.04%
==========================================
Files 398 398
Lines 50297 50310 +13
==========================================
- Hits 27793 27784 -9
- Misses 20171 20192 +21
- Partials 2333 2334 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
unknown tags can be counted under one substitute tag e.g. "UNK" limit protocol counters to known protocol tags
Summary
unknown tags can be counted under one substitute tag e.g. "UNK"
limit protocol counters to known protocol tags
Test Plan
Added unit test.