Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: TagCounter gains a tag set to filter on #4503

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

brianolson
Copy link
Contributor

Summary

unknown tags can be counted under one substitute tag e.g. "UNK"
limit protocol counters to known protocol tags

Test Plan

Added unit test.

unknown tags can be counted under one substitute tag e.g. "UNK"
limit protocol counters to known protocol tags
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #4503 (96aeba2) into master (e83acec) will decrease coverage by 0.03%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #4503      +/-   ##
==========================================
- Coverage   55.25%   55.22%   -0.04%     
==========================================
  Files         398      398              
  Lines       50297    50310      +13     
==========================================
- Hits        27793    27784       -9     
- Misses      20171    20192      +21     
- Partials     2333     2334       +1     
Impacted Files Coverage Δ
util/metrics/tagcounter.go 82.27% <81.81%> (-0.08%) ⬇️
network/wsPeer.go 65.66% <100.00%> (-2.83%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 69.59% <0.00%> (-0.60%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (-0.20%) ⬇️
catchup/service.go 68.88% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cce cce requested a review from winder August 31, 2022 21:19
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cce cce merged commit 3c64c26 into algorand:master Sep 8, 2022
onetechnical pushed a commit to onetechnical/go-algorand that referenced this pull request Sep 8, 2022
unknown tags can be counted under one substitute tag e.g. "UNK"
limit protocol counters to known protocol tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants