Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: pingpong nil fix #4558

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

brianolson
Copy link
Contributor

Summary

nil-hash-write bug fix

Test Plan

Found in testing. Later manual testing is better.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #4558 (3551b6e) into master (7e8ca90) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4558      +/-   ##
==========================================
- Coverage   54.11%   54.07%   -0.05%     
==========================================
  Files         401      401              
  Lines       51549    51551       +2     
==========================================
- Hits        27898    27877      -21     
- Misses      21311    21327      +16     
- Partials     2340     2347       +7     
Impacted Files Coverage Δ
shared/pingpong/accounts.go 3.40% <0.00%> (-0.02%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
network/wsPeer.go 68.19% <0.00%> (-2.70%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (-0.20%) ⬇️
catchup/service.go 69.38% <0.00%> (+0.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants