telemetry: add BlockAcceptedEventDetails.ReceivedAt to complement ValidatedAt #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. CI complains about msgp gen file. |
algorandskiy
approved these changes
Sep 24, 2022
This was referenced Sep 30, 2022
cce
added a commit
to cce/go-algorand
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to the ValidatedAt timing in #3703, this provides the timing of the winning payloadPresent messageEvent.
For more background, payloadPresent messageEvents are made when deserialized PP network messages arrive in demux.go here, and are converted into an messageEvent for handling in agreement:
https://github.com/algorand/go-algorand/blob/master/agreement/demux.go#L314-L318
https://github.com/algorand/go-algorand/blob/master/agreement/demux.go#L358-L377
Test Plan
Existing tests should pass.