Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use /v2/stateproofs API #4717

Closed
wants to merge 1 commit into from

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Nov 1, 2022

Summary

State proofs e2e tests should use the new /v2/stateproofs. This will support the migration from v1 to v2.

Test Plan

@id-ms id-ms changed the title use stateproof v2 api on tests Use v2/stateproofs API in tests Nov 1, 2022
@id-ms id-ms changed the title Use v2/stateproofs API in tests Algod: Use v2/stateproofs API in tests Nov 1, 2022
@id-ms id-ms changed the title Algod: Use v2/stateproofs API in tests algod: Use /v2/stateproofs API in tests Nov 1, 2022
@id-ms id-ms marked this pull request as ready for review November 1, 2022 09:44
@id-ms id-ms changed the title algod: Use /v2/stateproofs API in tests test: Use /v2/stateproofs API in tests Nov 1, 2022
@id-ms id-ms changed the title test: Use /v2/stateproofs API in tests test: Use /v2/stateproofs API Nov 1, 2022
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! It looks like some of the tests and lint check fails due to an issue in master, outside the scope of this PR. I will leave an approval and try to merge this into #4684 as well.

@michaeldiamant
Copy link
Contributor

Closing - To minimize confusion, I'm closing the PR because @algochoi cherry-picked the PR's change into #4684 as discussed in #4684 (comment).

Let's continue discussion + review in #4684.

@algoidan Thanks for your help here!

@id-ms id-ms deleted the use-stateproofapi-on-e2e branch May 16, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants