Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Delete v1 usage from client and remove V2 prefix from APIs #4767

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Nov 7, 2022

Summary

This PR removes

  • v1 algod usage for the internal REST client and any tests that test v1-exclusive APIs like TransactionByAddr.
  • legacy/deprecated goal commands that reference v1-exclusive APIs

The PR also removes the V2 prefix from client APIs, since we do not have to distinguish between v1 and v2 algod APIs.

Test Plan

CI Tests.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #4767 (133c820) into master (5c97463) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4767      +/-   ##
==========================================
+ Coverage   54.59%   54.68%   +0.09%     
==========================================
  Files         414      414              
  Lines       53646    53548      -98     
==========================================
- Hits        29286    29282       -4     
+ Misses      21935    21837      -98     
- Partials     2425     2429       +4     
Impacted Files Coverage Δ
cmd/goal/account.go 13.76% <0.00%> (+1.13%) ⬆️
cmd/goal/application.go 17.78% <0.00%> (ø)
cmd/goal/asset.go 15.75% <0.00%> (ø)
cmd/goal/clerk.go 8.75% <0.00%> (ø)
libgoal/libgoal.go 2.60% <0.00%> (+0.07%) ⬆️
libgoal/transactions.go 0.00% <0.00%> (ø)
shared/pingpong/accounts.go 2.78% <0.00%> (ø)
shared/pingpong/pingpong.go 0.00% <0.00%> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algochoi algochoi marked this pull request as ready for review November 8, 2022 15:41
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Thanks for splitting out a separate PR for v1 removals + final renames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants