Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable TestWebsocketNetworkTelemetryTCP on CI #4827

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

Disable TestWebsocketNetworkTelemetryTCP in CI builds since it cannot read actual metrics time to time

Test Plan

This is a test fix

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #4827 (ae26046) into master (60d0c09) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   54.20%   54.11%   -0.10%     
==========================================
  Files         419      419              
  Lines       53750    53750              
==========================================
- Hits        29137    29087      -50     
- Misses      22231    22279      +48     
- Partials     2382     2384       +2     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-2.70%) ⬇️
network/wsPeer.go 68.97% <0.00%> (-2.39%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/tracker.go 74.04% <0.00%> (-0.86%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 69.02% <0.00%> (-0.49%) ⬇️
network/requestTracker.go 70.81% <0.00%> (-0.43%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (+0.61%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cce cce merged commit fd9bd68 into algorand:master Nov 22, 2022
onetechnical pushed a commit to onetechnical/go-algorand that referenced this pull request Nov 22, 2022
algolucky pushed a commit to algolucky/go-algorand that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants