erl: Simplifications to public interfaces #5141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
- Coverage 53.47% 53.41% -0.07%
==========================================
Files 431 431
Lines 54364 54368 +4
==========================================
- Hits 29073 29041 -32
- Misses 23038 23068 +30
- Partials 2253 2259 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| if handler.checkAlreadyCommitted(wi) { | ||
| ac := handler.checkAlreadyCommitted(wi) | ||
| // mark the capacity as released, and as served too, if it's alreadyCommitted | ||
| wi.capguard.HandleCapguard() |
There was a problem hiding this comment.
this is not functionally equivalent to the original code: for each incoming wi Released is called in order to release capacity for a client. Then, Served called after some delay when wi gets actually queued into the verifier, so it could account for delays in batch verifier.
But I think this Served is misplaced and should be in case wi, ok := <-handler.postVerificationQueue: branch when we actually get wi verified by the batch signature verification.
@AlgoAxel @algonautshant opinions?
|
This makes the code more complex to understand |
I would like to propose these changes to ERL to simplify the calls from txHandler:
Based on my comments to:
#4797
and the proposed fixes here:
#5136