-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: peer selector expansion and PeersPhonebookArchivalNodes #5385
network: peer selector expansion and PeersPhonebookArchivalNodes #5385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5385 +/- ##
==========================================
+ Coverage 55.38% 55.48% +0.09%
==========================================
Files 447 447
Lines 63312 63351 +39
==========================================
+ Hits 35066 35148 +82
+ Misses 25854 25808 -46
- Partials 2392 2395 +3
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although ReadFromSRVPriority
is not used but it is implemented so that needs to be tested.
Co-authored-by: Bob Broderick <118225939+bbroder-algo@users.noreply.github.com>
1ba4a13
In this PR:
PeersPhonebookArchivalNodes
category of nodes is added, which is the same asPeersPhonebookRelays
for now.ReadFromSRVPriority
is added, which is similar toReadFromSRV
, but also retrieves the priority value of each record. Currently not used.