-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goal: Add initialize option to 'goal node catchup'. #5754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
- Coverage 55.45% 55.44% -0.01%
==========================================
Files 473 473
Lines 66683 66682 -1
==========================================
- Hits 36979 36972 -7
- Misses 27184 27189 +5
- Partials 2520 2521 +1
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, the new param name - maybe there are better options.
Summary
Add new parameter from #5752 to
goal node catchup
.Minor refactoring to command to try and simplify the operations. In particular things I didn't like:
args[0]
without saying anywhere that it was an optional positional argument.catchup
function references global abort flag, which is also referenced in the cobra function.Test Plan
Manually tested a bunch of permutations: