Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: fix dht-hybrid merge #5833

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

algorandskiy
Copy link
Contributor

Fix post-merge compilation error

@algorandskiy algorandskiy self-assigned this Nov 15, 2023
@algorandskiy algorandskiy merged commit 51a1b9d into algorand:feature/p2p Nov 15, 2023
14 checks passed
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (bcf71c1) 55.65% compared to head (9a604b6) 55.49%.
Report is 2 commits behind head on feature/p2p.

Files Patch % Lines
network/hybridNetwork.go 0.00% 106 Missing ⚠️
network/p2pNetwork.go 38.46% 24 Missing ⚠️
network/p2p/peerID.go 0.00% 21 Missing ⚠️
network/wsNetwork.go 57.89% 7 Missing and 1 partial ⚠️
node/node.go 14.28% 4 Missing and 2 partials ⚠️
network/netidentity.go 77.77% 4 Missing ⚠️
network/p2p/p2p.go 25.00% 3 Missing ⚠️
network/gossipNode.go 0.00% 2 Missing ⚠️
network/wsPeer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           feature/p2p    #5833      +/-   ##
===============================================
- Coverage        55.65%   55.49%   -0.16%     
===============================================
  Files              477      478       +1     
  Lines            66993    67161     +168     
===============================================
- Hits             37282    37272      -10     
- Misses           27178    27350     +172     
- Partials          2533     2539       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy added the p2p Work related to the p2p project label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p Work related to the p2p project Skip-Release-Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant