-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catchup: Fix empty cert if ledger already has a block #5846
Merged
algorandskiy
merged 4 commits into
algorand:master
from
algorandskiy:pavel/catchup-tests-fix2
Nov 28, 2023
Merged
catchup: Fix empty cert if ledger already has a block #5846
algorandskiy
merged 4 commits into
algorand:master
from
algorandskiy:pavel/catchup-tests-fix2
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5846 +/- ##
==========================================
+ Coverage 55.83% 55.87% +0.03%
==========================================
Files 477 477
Lines 67256 67259 +3
==========================================
+ Hits 37552 37580 +28
+ Misses 27171 27131 -40
- Partials 2533 2548 +15 ☔ View full report in Codecov by Sentry. |
jannotti
reviewed
Nov 27, 2023
jasonpaulos
reviewed
Nov 28, 2023
algorandskiy
commented
Nov 28, 2023
jasonpaulos
approved these changes
Nov 28, 2023
jannotti
approved these changes
Nov 28, 2023
gmalouf
approved these changes
Nov 28, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes nil pointer dereference in StoreBlock/StoreFirstBlock discovered by e2e catchup test.
It was introduced in #5798 and very similar to the
psp
fix in #4390Test Plan